Skip to content

test: set stable locale in shell scripts#324

Open
wangedmund77-cmyk wants to merge 1 commit into
BitgesellOfficial:masterfrom
wangedmund77-cmyk:codex/fix-shell-locale-lint
Open

test: set stable locale in shell scripts#324
wangedmund77-cmyk wants to merge 1 commit into
BitgesellOfficial:masterfrom
wangedmund77-cmyk:codex/fix-shell-locale-lint

Conversation

@wangedmund77-cmyk
Copy link
Copy Markdown

Summary

  • make shell scripts covered by lint-shell-locale.py explicitly opt out of locale-dependent behavior
  • move LC_ALL=C before set -eux in CI so it is the first non-comment command

Validation

  • python3 test/lint/lint-shell-locale.py
  • git diff --check

Refs #32.

@MyTH-zyxeon
Copy link
Copy Markdown

Review-assist for #324 under the Bitgesell improvement queue (#81):

  • Scope looks appropriately narrow: force LC_ALL=C before shell-sensitive commands so test/lint/lint-shell-locale.py stops depending on host locale state.
  • The most important acceptance point is making sure the changed scripts are exactly the ones the lint rule inspects. A quick paste of the python3 test/lint/lint-shell-locale.py output in the PR would make the intended coverage explicit.
  • Because this touches mixed sh/bash entrypoints and CI helpers, I would also sanity-check that moving LC_ALL=C ahead of set -eux in ci/retry/retry.sh is the only ordering-sensitive change and that no script relies on locale-specific sort/grep behavior elsewhere.
  • contrib/macdeploy/detached-sig-create.sh and share/qt/extract_strings_qt.py wrappers are good places for an extra smoke note, since packaging / string-extraction scripts often fail only on contributor machines rather than CI.
  • If maintainers consider this part of the #81 paid improvement lane, it would help to confirm the expected payout/claim path once the validation note is added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants